From: Vitaly Chikunov Date: Sat, 8 Jan 2022 23:25:31 +0000 (+0300) Subject: gost_ec_keyx: Check CTX data before it's really used X-Git-Tag: v3.0.1~10 X-Git-Url: http://wagner.pp.ru/gitweb/?a=commitdiff_plain;ds=inline;h=5dc8f91c186d88a74493c229c7afbf3eb40599a8;hp=5dc8f91c186d88a74493c229c7afbf3eb40599a8;p=openssl-gost%2Fengine.git gost_ec_keyx: Check CTX data before it's really used This should fix Coverity warning: *** CID 345243: Null pointer dereferences (REVERSE_INULL) /gost_ec_keyx.c: 681 in pkey_gost2018_decrypt() 675 o Q_eph is on the same curve as server public key; 676 677 o Q_eph is not equal to zero point; 678 679 o q * Q_eph is not equal to zero point. 680 */ >>> CID 345243: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "data" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 681 if (eph_key == NULL || priv == NULL || data == NULL) { 682 GOSTerr(GOST_F_PKEY_GOST2018_DECRYPT, 683 GOST_R_ERROR_COMPUTING_EXPORT_KEYS); 684 ret = 0; 685 goto err; 686 } Signed-off-by: Vitaly Chikunov Issue: #380 ---