From 4c5220630d819eb91a78bb9f7717335fb3e49c8c Mon Sep 17 00:00:00 2001 From: Dmitry Belyavskiy Date: Sat, 22 Aug 2020 18:42:56 +0300 Subject: [PATCH] Fix Coverity #305800 Plus some minor style fix --- benchmark/sign.c | 39 ++++++++++++++++++--------------------- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/benchmark/sign.c b/benchmark/sign.c index 7696b91..d9b08bb 100644 --- a/benchmark/sign.c +++ b/benchmark/sign.c @@ -40,27 +40,24 @@ static EVP_PKEY *create_key(const char *algname, const char *param) EVP_PKEY *key1 = EVP_PKEY_new(), *newkey = NULL; EVP_PKEY_CTX *ctx = NULL; - if(EVP_PKEY_set_type_str(key1, algname, strlen(algname)) <= 0) - { - goto err; - } - if(!(ctx = EVP_PKEY_CTX_new(key1, NULL))) - { - goto err; - } - EVP_PKEY_keygen_init(ctx); - if(ERR_peek_last_error()) - { - goto err; - } - if(EVP_PKEY_CTX_ctrl_str(ctx, "paramset", param) <= 0) - { - goto err; - } - if(EVP_PKEY_keygen(ctx, &newkey) <= 0) - { - goto err; - } + if (EVP_PKEY_set_type_str(key1, algname, strlen(algname)) <= 0) + goto err; + + if (!(ctx = EVP_PKEY_CTX_new(key1, NULL))) + goto err; + + if (EVP_PKEY_keygen_init(ctx) == 0) + goto err; + + if (ERR_peek_last_error()) + goto err; + + if (EVP_PKEY_CTX_ctrl_str(ctx, "paramset", param) <= 0) + goto err; + + if (EVP_PKEY_keygen(ctx, &newkey) <= 0) + goto err; + err: if(ctx) EVP_PKEY_CTX_free(ctx); -- 2.39.2